🤯 ID naming conventions across packages #1460
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for spirit-design-system failed. Why did it fail? →
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please, do a rebase. |
* the FileUploaderInput input element should never have the `required` attribute
cause it is use only for calling the dialog window
* the files are then stored in the queue
* for required validation is responsible the developer who is using this component
* the FileUploaderInput input element should never have the `required` attribute cause it is use only for calling the dialog window * the files are then stored in the queue * for required validation is responsible the developer who is using this component
pavelklibani
force-pushed
the
chore/ds-1267-id-naming
branch
from
762cc50 to
a03357e
Compare
|
ℹ️ created new PR: https://github.com/lmc-eu/spirit-design-system/pull/1462/files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft...