Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-twig): Make ValidationText and HelperText ID optional #DS-1336 #1470

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

crishpeen
Copy link
Member

Set aria-describedby to form elements when helperText or validationText set.

Description

Additional context

Issue reference

@github-actions github-actions bot added the bug Something isn't working label Jun 11, 2024
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 03c129d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66688318b2cc460008b53192

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 03c129d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6668831853152500099abf19
😎 Deploy Preview https://deploy-preview-1470--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 96.911%. remained the same
when pulling a4e6eb8 on fix/twig-validation-text-helper-text-id
into 8a6c985 on main.

@coveralls
Copy link

Coverage Status

coverage: 77.762% (-19.1%) from 96.911%
when pulling a4e6eb8 on fix/twig-validation-text-helper-text-id
into 8a6c985 on main.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 👍🏻

Set aria-describedby to form elements when helperText
or validationText set.
@crishpeen crishpeen force-pushed the fix/twig-validation-text-helper-text-id branch from a4e6eb8 to 03c129d Compare June 11, 2024 17:02
@coveralls
Copy link

Coverage Status

coverage: 96.911%. remained the same
when pulling 03c129d on fix/twig-validation-text-helper-text-id
into 8a6c985 on main.

@coveralls
Copy link

Coverage Status

coverage: 77.762% (-19.1%) from 96.911%
when pulling 03c129d on fix/twig-validation-text-helper-text-id
into 8a6c985 on main.

@crishpeen crishpeen requested review from dlouhak and curdaj June 11, 2024 19:07
@literat literat merged commit 0e2feea into main Jun 12, 2024
26 checks passed
@literat literat deleted the fix/twig-validation-text-helper-text-id branch June 12, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants