Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test(ci): Allow unstable components safely fail E2E tests #1520

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Jun 26, 2024

Description

  • when an unstable component fails due to a missing technology the test will fail but the suite will pass

Additional context

I have added the try ... catch block and rethrow the error in case of the stable components.

Issue reference

@literat literat requested a review from a team as a code owner June 26, 2024 14:28
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Jun 26, 2024
@literat literat requested a review from crishpeen June 26, 2024 14:29
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 6e8924d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/667e926c33140d000892b31d

@literat literat requested review from pavelklibani and curdaj June 26, 2024 14:29
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6e8924d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/667e926ca3c3e00009d7957d
😎 Deploy Preview https://deploy-preview-1520--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat requested a review from adamkudrna June 26, 2024 14:29
@literat literat added the run-visual-tests Runs visual regression testing on this PR label Jun 26, 2024
Copy link
Contributor

@coveralls
Copy link

Coverage Status

coverage: 78.141%. remained the same
when pulling 2103ab6 on chore/allow-unstable-to-pass-test
into 877d604 on main.

@coveralls
Copy link

Coverage Status

coverage: 78.141%. remained the same
when pulling 9d64108 on chore/allow-unstable-to-pass-test
into 877d604 on main.

@coveralls
Copy link

Coverage Status

coverage: 78.141%. remained the same
when pulling f505f1b on chore/allow-unstable-to-pass-test
into 877d604 on main.

  * when unstable component fail due to a missing technology the test will fail
    but the suite will pass
@literat literat force-pushed the chore/allow-unstable-to-pass-test branch from f505f1b to 6e8924d Compare June 28, 2024 10:37
@coveralls
Copy link

Coverage Status

Changes unknown
when pulling 6e8924d on chore/allow-unstable-to-pass-test
into ** on main**.

@literat literat merged commit bd74198 into main Jun 28, 2024
23 checks passed
@literat literat deleted the chore/allow-unstable-to-pass-test branch June 28, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants