Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Change relative path to absolute path in md #DS-1364 #1534

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jul 2, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 2, 2024
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2e68088
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/668cf79dfd70370008b6ac2b
😎 Deploy Preview https://deploy-preview-1534--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 2e68088
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/668cf79d4f38c30008e2aa24
😎 Deploy Preview https://deploy-preview-1534--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat
Copy link
Collaborator

literat commented Jul 3, 2024

Looks good. 👍 Still searching for relative paths?

@curdaj curdaj force-pushed the docs/ds-1364-absolute-path branch from 6e9ba51 to 35461bf Compare July 4, 2024 12:28
@coveralls
Copy link

Coverage Status

coverage: 78.921% (+0.8%) from 78.141%
when pulling 35461bf on docs/ds-1364-absolute-path
into e8a50d9 on main.

@coveralls
Copy link

Coverage Status

coverage: 78.921% (+0.8%) from 78.141%
when pulling c504e58 on docs/ds-1364-absolute-path
into e8a50d9 on main.

@curdaj curdaj marked this pull request as ready for review July 4, 2024 12:44
@coveralls
Copy link

Coverage Status

coverage: 78.141%. remained the same
when pulling c504e58 on docs/ds-1364-absolute-path
into e8a50d9 on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

README.md Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jul 8, 2024

Coverage Status

Changes unknown
when pulling 2e68088 on docs/ds-1364-absolute-path
into ** on main**.

Copy link
Contributor

@dlouhak dlouhak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix but otherwise LGTM 💪🏻

packages/web-twig/README.md Outdated Show resolved Hide resolved
packages/web/README.md Outdated Show resolved Hide resolved
@curdaj curdaj force-pushed the docs/ds-1364-absolute-path branch from 0dfec32 to c0290df Compare July 8, 2024 09:21
@curdaj curdaj force-pushed the docs/ds-1364-absolute-path branch from e7a73df to 2e68088 Compare July 9, 2024 08:41
@curdaj curdaj merged commit ebd2b3f into main Jul 9, 2024
29 checks passed
@curdaj curdaj deleted the docs/ds-1364-absolute-path branch July 9, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants