Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spirit Tokens & Styles (Spirit SCSS Exporter) #1549

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Spirit Tokens & Styles (Spirit SCSS Exporter) #1549

merged 3 commits into from
Jul 25, 2024

Conversation

supernovaio[bot]
Copy link
Contributor

@supernovaio supernovaio bot commented Jul 18, 2024

New tokens and styles based on data from Spirit

@supernovaio supernovaio bot requested review from literat, adamkudrna, crishpeen and a team as code owners July 18, 2024 09:55
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 59c3cc7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/669fc645e9a6f5000956ca81
😎 Deploy Preview https://deploy-preview-1549--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 18, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 59c3cc7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/669fc645085d7800089c4318

@crishpeen crishpeen force-pushed the supernova/spirit-scss-exporter branch from abf048c to 74d8369 Compare July 23, 2024 14:51
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Jul 23, 2024
@coveralls
Copy link

coveralls commented Jul 23, 2024 •
edited
Loading

Coverage Status

coverage: 78.187% (-0.8%) from 78.944%
when pulling 59c3cc7 on supernova/spirit-scss-exporter
into 0efd6f6 on main.

@crishpeen crishpeen merged commit 2cc2b49 into main Jul 25, 2024
15 checks passed
@crishpeen crishpeen deleted the supernova/spirit-scss-exporter branch July 25, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlouhak dlouhak dlouhak left review comments

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

Assignees
No one assigned
Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coveralls @literat @crishpeen @dlouhak