Feat(web, web-twig, web-react): Introduce prop underline to Link component
#1565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pavelklibani
commented
Aug 5, 2024
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen,
a team and
curdaj
as code owners
pavelklibani
force-pushed
the
feat/ds-943-link-underline
branch
from
102130c to
f6b8bf2
Compare
literat
approved these changes
Aug 7, 2024
crishpeen
requested changes
Aug 7, 2024
packages/web-twig/src/Resources/components/Link/stories/LinkUnderline.twig
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Link/Link.stories.twig
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Link/__tests__/useLinkStyleProps.test.ts
Show resolved
Hide resolved
packages/web-react/src/components/Link/__tests__/useLinkStyleProps.test.ts
Show resolved
Hide resolved
crishpeen
reviewed
Aug 7, 2024
pavelklibani
force-pushed
the
feat/ds-943-link-underline
branch
from
8e2ffb6 to
8965d7f
Compare
pavelklibani
force-pushed
the
feat/ds-943-link-underline
branch
from
8965d7f to
e79223a
Compare
curdaj
approved these changes
Aug 9, 2024
crishpeen
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Good work!
We just need to document the deprecations more.
There should be mention in both of these files:
- packages/web-react/DEPRECATIONS.md
- packages/web-twig/DEPRECATIONS.md
If I remember correctly, there could be a migration guide as well. So we can then copy it to the migration instructions.
Deprecation files updated, thank you for remebering! |
- Add new prop `underlined` to Link component - Deprecate prop `isUnderlined` in Link component - Update demo and stories for Link component Solves #DS-943
- Add new prop `underlined` to Link component - Deprecate prop `isUnderlined` in Link component - Update demo for Link component Solves #DS-943
- replacing the `isUnderlined` prop with a new `underlined` prop and set it to "always" if true
pavelklibani
force-pushed
the
feat/ds-943-link-underline
branch
from
b7da21c to
9b260f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
underlineto Link componentisUnderlinein Link componentIssue reference
Podtržení odkazů na hover je někdy nežádoucí