Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(design-tokens): Fix and rename Vite config #1585

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

literat
Copy link
Collaborator

@literat literat commented Aug 19, 2024

Description

  • The CJS build of Vite's Node API is deprecated.

Use Node module resolution to fix the problem with Vite build

Additional context

https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated

Issue reference

@literat literat requested review from adamkudrna, crishpeen and a team as code owners August 19, 2024 12:58
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Aug 19, 2024
Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit aac09e6
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66cda15eacfe220008d85879

Copy link

netlify bot commented Aug 19, 2024

Deploy Preview for spirit-design-system failed. Why did it fail? →

Name Link
🔨 Latest commit aac09e6
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66cda15e4d38330008216e7b

@coveralls
Copy link

coveralls commented Aug 19, 2024

Coverage Status

coverage: 78.449%. remained the same
when pulling aac09e6 on chore/design-tokens-vite-config
into ec96d80 on main.

@crishpeen
Copy link
Member

Do we plan to do this in all packages?

@literat literat force-pushed the chore/design-tokens-vite-config branch from 4ea4581 to f2f0ae6 Compare August 21, 2024 07:14
@literat
Copy link
Collaborator Author

literat commented Aug 21, 2024

Do we plan to do this in all packages?

Thanks for your note, I have fixed this in all vite.config files.

@literat literat force-pushed the chore/design-tokens-vite-config branch from a6aeaf5 to aac09e6 Compare August 27, 2024 09:50
@literat literat merged commit 3755821 into main Aug 27, 2024
17 of 21 checks passed
@literat literat deleted the chore/design-tokens-vite-config branch August 27, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants