-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore(design-tokens): Fix and rename Vite config #1585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
maintenance
Changes to the build process or auxilary tools and libraries or other maintenance
label
Aug 19, 2024
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
❌ Deploy Preview for spirit-design-system failed. Why did it fail? →
|
Do we plan to do this in all packages? |
literat
force-pushed
the
chore/design-tokens-vite-config
branch
from
August 21, 2024 07:14
4ea4581
to
f2f0ae6
Compare
Thanks for your note, I have fixed this in all |
… of deprecated api * The CJS build of Vite's Node API is deprecated. * @see https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
…f deprecated api * The CJS build of Vite's Node API is deprecated. * @see https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
… of deprecated api * The CJS build of Vite's Node API is deprecated. * @see https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
…on becuase of deprecated api * The CJS build of Vite's Node API is deprecated. * @see https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
literat
force-pushed
the
chore/design-tokens-vite-config
branch
from
August 27, 2024 09:50
a6aeaf5
to
aac09e6
Compare
pavelklibani
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
maintenance
Changes to the build process or auxilary tools and libraries or other maintenance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Node module resolution to fix the problem with Vite build
Additional context
https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
Issue reference