Feat(web, web-react): PartnerLogo - prep for the stabilization
#1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
👷 Deploy Preview for spirit-design-system-storybook processing.
|
pavelklibani
changed the base branch from
main
to
integration/BC-v3-design-tokens
pavelklibani
force-pushed
the
feat/ds-1373-partner-logo-prep
branch
from
72cf161 to
f17f65e
Compare
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
approved these changes
Sep 6, 2024
curdaj
reviewed
Sep 10, 2024
...ges/web-react/src/components/UNSTABLE_PartnerLogo/__tests__/usePartnerLogoStyleProps.test.ts
Outdated
Show resolved
Hide resolved
...ges/web-react/src/components/UNSTABLE_PartnerLogo/__tests__/usePartnerLogoStyleProps.test.ts
Show resolved
Hide resolved
...ges/web-react/src/components/UNSTABLE_PartnerLogo/__tests__/usePartnerLogoStyleProps.test.ts
Outdated
Show resolved
Hide resolved
curdaj
approved these changes
Sep 10, 2024
crishpeen
approved these changes
Sep 10, 2024
packages/web-react/src/components/UNSTABLE_PartnerLogo/stories/UNSTABLE_PartnerLogo.stories.tsx
Show resolved
Hide resolved
packages/web-react/src/components/UNSTABLE_PartnerLogo/usePartnerLogoStyleProps.ts
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/UNSTABLE_PartnerLogo/usePartnerLogoStyleProps.ts
Outdated
Show resolved
Hide resolved
pavelklibani
force-pushed
the
feat/ds-1373-partner-logo-prep
branch
from
f17f65e to
383d1b4
Compare
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10792318014/artifacts/1914107636 |
… in `PartnerLogo` class - Preparation for stabilization of the `PartnerLogo` component - Solves #DS-1373
…in `PartnerLogo` component - Default value of `hasSafeArea` changed to `true` - Preparation for stabilization of the PartnerLogo component - Solves #DS-1373
pavelklibani
force-pushed
the
feat/ds-1373-partner-logo-prep
branch
from
383d1b4 to
c3144ae
Compare
|
ℹ️ rebased to actual integration/BC-v3-design-tokens |
pavelklibani
merged commit 303f914
into
integration/BC-v3-design-tokens
21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
safeAreafromhasSafeAreaDisabledhasSafeAreaDisabled->hasSafeAreaand default value changed fromfalse->trueAdditional context
Issue reference
PartnerLogo - preparation for the stabilization