BREAKING CHANGE(web): Switch FieldGroup component to v3 design tokens and improve alignment #DS-1447 #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani,
curdaj and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
force-pushed
the
feat/v3-radio
branch
2 times, most recently
from
a8f19af to
1f44e84
Compare
|
Rebase is needed 🙏 |
crishpeen
force-pushed
the
feat/v3-radio
branch
from
1f44e84 to
883f5b5
Compare
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
d0af965 to
0000c0f
Compare
crishpeen
force-pushed
the
feat/v3-radio
branch
from
883f5b5 to
82d5908
Compare
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
0000c0f to
ee89f70
Compare
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10897983108/artifacts/1941189573 |
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
ee89f70 to
e181bb9
Compare
crishpeen
force-pushed
the
feat/v3-radio
branch
3 times, most recently
from
1979090 to
6ca40b5
Compare
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
e181bb9 to
ae70e08
Compare
adamkudrna
reviewed
Sep 17, 2024
crishpeen
force-pushed
the
feat/v3-radio
branch
2 times, most recently
from
b4b1376 to
6a7df65
Compare
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
ae70e08 to
3e37d72
Compare
Base automatically changed from
feat/v3-radio
to
integration/BC-v3-design-tokens
September 17, 2024 14:08
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
3e37d72 to
444e45d
Compare
crishpeen
changed the title
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/10905087812/artifacts/1943072920 |
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
444e45d to
b95bf82
Compare
crishpeen
force-pushed
the
integration/BC-v3-design-tokens
branch
from
c0b2966 to
2a43cd8
Compare
… and improve alignment #DS-1447 Align FieldGroup fields to start if not fluid.
crishpeen
force-pushed
the
feat/v3-fieldgroup
branch
from
b95bf82 to
6ae3b38
Compare
adamkudrna
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference