Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Switch Item component to v3 design tokens #DS-1451 #1648

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Feat(web): Switch Item component to v3 design tokens #DS-1451 #1648

merged 2 commits into from
Sep 19, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Sep 17, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 9a3262f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66ec110f0cb8ac0008253102

@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 9a3262f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66ec110f78d01400080d1558
😎 Deploy Preview https://deploy-preview-1648--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 17, 2024 •
edited
Loading

Coverage Status

coverage: 78.69% (-0.8%) from 79.452%
when pulling 9a3262f on feat/v3-item
into 8c59b37 on integration/BC-v3-design-tokens.

adamkudrna
adamkudrna requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacings need to be changed. Also we use different color tokens, but I believe this should be rather addressed in Figma.

packages/web/src/scss/components/Item/_theme.scss Show resolved Hide resolved
packages/web/src/scss/tools/_form-fields.scss Show resolved Hide resolved
@crishpeen crishpeen mentioned this pull request Sep 17, 2024
Merged
@crishpeen crishpeen force-pushed the feat/v3-item branch 2 times, most recently from a2a51e0 to efe22cb Compare September 19, 2024 10:52
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 2d42419 to 70fab2b Compare September 19, 2024 11:09
@crishpeen crishpeen force-pushed the feat/v3-item branch 2 times, most recently from cede577 to 7fc5636 Compare September 19, 2024 11:28
@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Sep 19, 2024
@crishpeen crishpeen force-pushed the integration/BC-v3-design-tokens branch from 70fab2b to 8c59b37 Compare September 19, 2024 11:41
@crishpeen crishpeen merged commit 2db07ea into integration/BC-v3-design-tokens Sep 19, 2024
17 checks passed
@crishpeen crishpeen deleted the feat/v3-item branch September 19, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat Awaiting requested review from literat

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @coveralls @adamkudrna