Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web-twig): Redesign the demo app #DS-1479 #1675

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Docs(web-twig): Redesign the demo app #DS-1479 #1675

merged 1 commit into from
Oct 3, 2024

Conversation

adamkudrna
Copy link
Contributor

Description

Include header and footer on all demo pages for easier navigation.

Additional context

obrazek

Issue reference

https://jira.almacareer.tech/browse/DS-1479

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 1, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 0172f1a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66fe6511c64ce0000828f038
😎 Deploy Preview https://deploy-preview-1675--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Oct 1, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 0172f1a
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66fe6511aeb8260008d1cae0
😎 Deploy Preview https://deploy-preview-1675--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 7 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Coverage Status

coverage: 78.791%. remained the same
when pulling 0172f1a on docs/redesign-twig-demo-app
into 7acd02d on integration/BC-v3-design-tokens.

@adamkudrna adamkudrna force-pushed the docs/redesign-with-theme-switcher branch from a86bccf to c09a825 Compare October 1, 2024 15:38
@adamkudrna adamkudrna force-pushed the docs/redesign-twig-demo-app branch from 97894bd to 9d6c2f8 Compare October 1, 2024 15:38
This was referenced Oct 1, 2024
Merged
Merged
crishpeen
crishpeen reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use TwigX and spacing props everywhere where possible.

apps/web-twig-demo/templates/helpers.html.twig Outdated Show resolved Hide resolved
apps/web-twig-demo/templates/layout/base.html.twig Outdated Show resolved Hide resolved
apps/web-twig-demo/templates/partials/cover.html.twig Outdated Show resolved Hide resolved
apps/web-twig-demo/templates/partials/cover.html.twig Show resolved Hide resolved
apps/web-twig-demo/templates/partials/cover.html.twig Show resolved Hide resolved
apps/web-twig-demo/templates/partials/header.html.twig Show resolved Hide resolved
apps/web-twig-demo/templates/partials/tabs.html.twig Outdated Show resolved Hide resolved
apps/web-twig-demo/templates/partials/tabs.html.twig Outdated Show resolved Hide resolved
apps/web-twig-demo/templates/validations.html.twig Outdated Show resolved Hide resolved
packages/web-twig/src/Resources/icons/Icons.stories.twig Outdated Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the docs/redesign-with-theme-switcher branch from 824634c to 6ebc564 Compare October 3, 2024 08:34
@adamkudrna adamkudrna requested a review from curdaj as a code owner October 3, 2024 08:34
Base automatically changed from docs/redesign-with-theme-switcher to integration/BC-v3-design-tokens October 3, 2024 08:43
@adamkudrna adamkudrna force-pushed the docs/redesign-twig-demo-app branch from 9d6c2f8 to 95cbb8a Compare October 3, 2024 09:29
@adamkudrna
Docs(web-twig): Redesign the demo app #DS-1479
0172f1a 
Include header and footer on all demo pages for easier navigation.
@adamkudrna adamkudrna force-pushed the docs/redesign-twig-demo-app branch from 95cbb8a to 0172f1a Compare October 3, 2024 09:34
@crishpeen crishpeen merged commit 97099d8 into integration/BC-v3-design-tokens Oct 3, 2024
26 checks passed
@crishpeen crishpeen deleted the docs/redesign-twig-demo-app branch October 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat Awaiting requested review from literat

@pavelklibani pavelklibani Awaiting requested review from pavelklibani

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@adamkudrna adamkudrna

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamkudrna @coveralls @crishpeen