Fix(web-react, web-twig): PasswordToggle disabled #DS-1478 #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen,
a team and
curdaj
as code owners
pavelklibani
added
run-visual-tests
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pavelklibani
changed the title
crishpeen
approved these changes
Oct 2, 2024
...-twig/src/Resources/components/TextField/__tests__/__fixtures__/textFieldPasswordToggle.twig
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/TextField/__tests__/TextField.test.tsx
Outdated
Show resolved
Hide resolved
crishpeen
approved these changes
Oct 3, 2024
pavelklibani
force-pushed
the
fix/ds-1478-password-toggle-disabled
branch
from
9dd0adf to
512d0e6
Compare
curdaj
approved these changes
Oct 3, 2024
pavelklibani
force-pushed
the
fix/ds-1478-password-toggle-disabled
branch
from
527e898 to
928056b
Compare
literat
requested changes
Oct 3, 2024
pavelklibani
force-pushed
the
fix/ds-1478-password-toggle-disabled
branch
from
928056b to
fbd630e
Compare
pavelklibani
force-pushed
the
fix/ds-1478-password-toggle-disabled
branch
from
fbd630e to
3f2fbea
Compare
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
Password Toggle button should be disabled if the TextField is disabled