Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(form-validations): Fix form IDs in form-validations demo #1682

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Oct 3, 2024

Description

The form validation demo was not validating

@pavelklibani pavelklibani self-assigned this Oct 3, 2024
@pavelklibani pavelklibani requested review from literat, curdaj and a team as code owners October 3, 2024 11:56
@github-actions github-actions bot added the bug Something isn't working label Oct 3, 2024
Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 9b85f93
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66fe867af6e0b00008aeb907

Copy link

netlify bot commented Oct 3, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 9b85f93
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66fe867a87243000081cc58f
😎 Deploy Preview https://deploy-preview-1682--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.751%. remained the same
when pulling 9b85f93 on fix/form-validations-demo
into 460f31a on main.

@pavelklibani pavelklibani merged commit dbd2d5d into main Oct 7, 2024
15 checks passed
@pavelklibani pavelklibani deleted the fix/form-validations-demo branch October 7, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants