-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING-CHANGE: Renamed variables-scss to tokens-exporter and add assets-exporter #DS-1483 #1695
Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
I suggest use only |
4e3c92d
to
1e60b71
Compare
Agree that |
rebased with main (fixed supernova bug - updated versions etc.) |
d03587d
to
653172a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job. It is looking good. I have made a few nice-to-have suggestions.
Also, it comes to mind that it might be appropriate to deprecate the svg
, js
, and scss
exporters. I mean like write some sentence into the exporters readmes: This exporter is deprecated. Use ... instead.
And link to the new exporter code.
I know that is under our control, but for history's sake :-) Thanks.
I don't think so we want to deprecate these exporters in We can do this when we merge v3 (or we can deprecate it in the integration branch). @literat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the commit message scope in the first commit.
653172a
to
35d66d5
Compare
…xporter-tokens #DS-1483
- preparation for renaming the svg exporter to assets exporter in the future
35d66d5
to
6db0f52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
Additional context
Issue reference