BC(web): Toast JS plugin isUnderlined changed to underlined
#1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen,
a team and
curdaj
as code owners
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
reviewed
Oct 17, 2024
packages/web-twig/src/Resources/components/Toast/__tests__/__fixtures__/toastBarLink.twig
Show resolved
Hide resolved
literat
force-pushed
the
integration/BC-v3-design-tokens
branch
from
83df04c to
33d2629
Compare
- `isUnderlined` changed to `underlined` in `Toast` JS plugin to better reflect changes in react and twig `Link` component - solves #DS-1509
- `isUnderlined` changed to `underlined` in documentation of `Toast` JS plugin to better reflect changes in react and twig `Link` component and changes in web plugin - Removed isUnderlined prop from ToastBarLink test fixture because this prop does not exist on this component - solves #DS-1509
pavelklibani
force-pushed
the
feat/ds-1509-underlined-link-in-toast
branch
from
6c519aa to
766fa55
Compare
crishpeen
approved these changes
Oct 17, 2024
packages/web-twig/src/Resources/components/Toast/__tests__/__fixtures__/toastBarLink.twig
Show resolved
Hide resolved
pavelklibani
merged commit 912c9b2
into
integration/BC-v3-design-tokens
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update of
ToastJS plugin where you can set underline of link inside of aToastcomponentalways, as it wasisUnderlined={true}beforeAdditional context
Moved forgotten deprecations about underline to migration guide in twig
Issue reference
Remove
isUnderlinedprop from Link