Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNSAFE classname test #1826

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Dec 18, 2024

Description

  • Our Spirit components still require UNSAFE_className, UNSAFE_style
  • Third party components required their own props - className, style, etc.

Warning

Some components are still broken and will need to be fixed in upcoming changes.
The problem is that some components spread their props, while others combine classes inline.

Additional context

Note

Testing demo available at Next.js app router: http://localhost:3000/test1

Issue reference

(UNSAFE_)className v elementType komponentach

@pavelklibani pavelklibani self-assigned this Dec 18, 2024
@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Dec 18, 2024
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit ca89643
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/6762e1682b87830009e119ba
😎 Deploy Preview https://deploy-preview-1826--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 1 from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit ca89643
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6762e1683725fc000858795e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant