Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch back to heading capitalization official package #1829

Merged
merged 3 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .remarkrc.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ export default {
'remark-lint-heading-capitalization',
{
lowerCaseWords: ['v1', 'v2', 'v3', 'v4', 'vs'],
exclude: ['`web`', '`web-react`'],
ignorePattern: ['^@lmc-eu/spirit-.*', '^spirit-.*', '`.*`', '.*-config-spirit'],
ignorePattern: ['^@lmc-eu/spirit-[a-z-]+', '^spirit-[a-z-]+', '`[^`]+`', '[a-z-]+-config-spirit'],
},
],

Expand Down
2 changes: 1 addition & 1 deletion configs/typescript-config-spirit/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

> TypeScript configuration and utilities for Spirit Design System.

## Getting started
## Getting Started

To install `typescript-config-spirit` in your project, you will need to run the
following command using [Yarn][yarn]:
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"types": "yarn packages:types",
"lint": "npm-run-all --parallel es:lint lint:markdown packages:lint",
"lint:fix": "npm-run-all --parallel es:lint:fix packages:lint:fix",
"lint:markdown": "remark ./ --quiet",
"lint:markdown": "remark ./ --quiet --frail",
"lint:commit": "yarn commitlint --verbose --color --from $(git merge-base origin/main HEAD)",
"packages:lint:fix": "lerna run lint:fix --parallel",
"packages:lint": "lerna run lint --parallel --no-sort",
Expand Down Expand Up @@ -94,7 +94,7 @@
"react-dom": "18.3.1",
"remark-cli": "12.0.1",
"remark-frontmatter": "5.0.0",
"remark-lint-heading-capitalization": "https://github.com/literat/remark-lint-heading-capitalization.git",
"remark-lint-heading-capitalization": "1.3.0",
"sass-loader": "14.2.1",
"style-loader": "4.0.0",
"typescript": "4.7.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/web-react/src/components/FileUploader/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ For example:
To limit files to 1 MiB, set `maxFileSize` to **1048576**.
To limit files to 10 MiB, set `maxFileSize` to **10485760**.

#### Kilo/Mega vs. Kibi/Mebi
#### Kilo/Mega vs Kibi/Mebi

In computing, file sizes can be measured using two different standards.
The **decimal** (base-10) and **binary** (base-2) systems.
Expand Down
2 changes: 2 additions & 0 deletions packages/web-react/src/components/Grid/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,8 @@ These props control the placement of grid items within a CSS Grid layout by spec

<img src="https://raw.githubusercontent.com/lmc-eu/spirit-design-system/refs/heads/main/packages/web-react/src/components/Grid/static/GridExample.svg" alt="Grid example" width="400" />

<!--lint ignore no-emphasis-as-heading-->

_The image is taken from the [CSS Grid Layout Guide][css-tricks-grid]._

These props align with their respective CSS Grid properties, providing precise control over grid item placement. Learn more in the [MDN CSS Grid][grid-mdn] documentation.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ attributes to register trigger events.
| Name | Type | Default | Required | Description |
| --------------- | -------------------------------------------- | -------------- | -------- | ------------------------- |
| `elementType` | `string` | `div` | ✕ | HTML tag to render |
| `fullWidthMode` | \[`off,mobile-only,all`]` | — | ✕ | Full-width mode |
| `fullWidthMode` | \[`off,mobile-only,all`] | — | ✕ | Full-width mode |
| `id` | `string` | — | ✓ | DropdownPopover ID |
| `placement` | [Placement Dictionary][dictionary-placement] | `bottom-start` | ✕ | Placement of the dropdown |

Expand Down
2 changes: 2 additions & 0 deletions packages/web-twig/src/Resources/components/Grid/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ These props control the placement of grid items within a CSS Grid layout by spec

<img src="https://raw.githubusercontent.com/lmc-eu/spirit-design-system/refs/heads/main/packages/web-react/src/components/Grid/static/GridExample.svg" alt="Grid example" width="400" />

<!--lint ignore no-emphasis-as-heading-->

_The image is taken from the [CSS Grid Layout Guide][css-tricks-grid]._

These props align with their respective CSS Grid properties, providing precise control over grid item placement. Learn more in the [MDN CSS Grid][grid-mdn] documentation.
Expand Down
4 changes: 3 additions & 1 deletion packages/web/src/scss/components/Dropdown/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@
</div>
```

## Usage with [Item][item] Component
literat marked this conversation as resolved.
Show resolved Hide resolved
## Usage with Item Component

See the [Item][item] component for more information.

```html
<div class="Dropdown">
Expand Down
2 changes: 2 additions & 0 deletions packages/web/src/scss/components/Grid/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ These props control the placement of grid items within a CSS Grid layout by spec

<img src="https://raw.githubusercontent.com/lmc-eu/spirit-design-system/refs/heads/main/packages/web-react/src/components/Grid/static/GridExample.svg" alt="Grid example" width="400" />

<!--lint ignore no-emphasis-as-heading-->

_The image is taken from the [CSS Grid Layout Guide][css-tricks-grid]._

Learn more about grid placement in the [MDN CSS Grid][grid-mdn] documentation.
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -25680,13 +25680,13 @@ __metadata:
languageName: node
linkType: hard

"remark-lint-heading-capitalization@https://github.com/literat/remark-lint-heading-capitalization.git":
version: 1.2.0
resolution: "remark-lint-heading-capitalization@https://github.com/literat/remark-lint-heading-capitalization.git#commit=a040dd376a609daf5d193536d553b19af59c1487"
"remark-lint-heading-capitalization@npm:1.3.0":
version: 1.3.0
resolution: "remark-lint-heading-capitalization@npm:1.3.0"
dependencies:
unified-lint-rule: "npm:^2.1.2"
unist-util-visit: "npm:^5.0.0"
checksum: 10/e8d9b0734cade299381bcc7e46102bde912f569d8d18c1e344e9dd9be653a0c8342f8588935de6db48d0d37dcc1d48e5fbd2809ece840539545cd1493a2e498a
checksum: 10/34454930e8dd04ee96b38713b8e37c50070d280ea0063ae08b54c081b7163954bd9af01f0b01328abd0d2c560dba8d5b4713c67e2da0d0e8f40f5a7d408f401b
languageName: node
linkType: hard

Expand Down Expand Up @@ -27886,7 +27886,7 @@ __metadata:
react-dom: "npm:18.3.1"
remark-cli: "npm:12.0.1"
remark-frontmatter: "npm:5.0.0"
remark-lint-heading-capitalization: "https://github.com/literat/remark-lint-heading-capitalization.git"
remark-lint-heading-capitalization: "npm:1.3.0"
sass-loader: "npm:14.2.1"
style-loader: "npm:4.0.0"
typescript: "npm:4.7.4"
Expand Down
Loading