Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Introduce Box component #DS-1595 #1830

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Feat: Introduce Box component #DS-1595 #1830

merged 3 commits into from
Jan 2, 2025

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Dec 23, 2024

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Dec 23, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 264396b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/677685140ed740000826e810

@netlify Netlify
Copy link

netlify bot commented Dec 23, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 264396b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67768514f8bdaf000873997e
😎 Deploy Preview https://deploy-preview-1830--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Dec 23, 2024
@curdaj curdaj force-pushed the feat/ds-1595-box-component branch 4 times, most recently from dd079fc to 4241e5b Compare December 23, 2024 10:59
@lmc-eu lmc-eu deleted a comment from github-actions bot Dec 23, 2024
@lmc-eu lmc-eu deleted a comment from github-actions bot Dec 23, 2024
@lmc-eu lmc-eu deleted a comment from github-actions bot Dec 23, 2024
@lmc-eu lmc-eu deleted a comment from github-actions bot Dec 23, 2024
@lmc-eu lmc-eu deleted a comment from github-actions bot Dec 23, 2024
@lmc-eu lmc-eu deleted a comment from github-actions bot Dec 23, 2024
@curdaj curdaj marked this pull request as ready for review December 23, 2024 11:04
crishpeen
crishpeen reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add border style utility and borderStyle prop. So we don't need inline style.

Otherwise LGTM!

packages/web-react/src/components/Box/demo/BoxWithBackgroundColor.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Box/demo/index.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Box/stories/Box.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/types/box.ts Outdated Show resolved Hide resolved
packages/web/src/scss/components/Box/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/settings/_utilities.scss Show resolved Hide resolved
pavelklibani
pavelklibani requested changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add Box component to entry points in React:
packages/web-react/scripts/entryPoints.js

packages/web-react/src/components/Box/stories/Box.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Box/useBoxStyleProps.ts Show resolved Hide resolved
packages/web-react/src/components/Box/README.md Outdated Show resolved Hide resolved
@curdaj curdaj force-pushed the feat/ds-1595-box-component branch from 3e5dcb7 to dc0fb7f Compare December 31, 2024 10:19
crishpeen
crishpeen approved these changes Jan 2, 2025
View reviewed changes
packages/web/src/scss/components/Box/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Box/README.md Show resolved Hide resolved
packages/web-react/src/types/box.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Box/useBoxStyleProps.ts Outdated Show resolved Hide resolved
packages/web-react/src/components/Box/stories/Box.stories.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Box/README.md Show resolved Hide resolved
@curdaj curdaj force-pushed the feat/ds-1595-box-component branch from bfe187d to 264396b Compare January 2, 2025 12:22
@curdaj curdaj merged commit 7a4106f into main Jan 2, 2025
23 checks passed
@curdaj curdaj deleted the feat/ds-1595-box-component branch January 2, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat Awaiting requested review from literat literat is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@curdaj curdaj

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curdaj @crishpeen @pavelklibani