Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Add prefixed utility class #DS-1618 #1848

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Feat(web-react): Add prefixed utility class #DS-1618 #1848

merged 1 commit into from
Jan 15, 2025

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jan 13, 2025

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Jan 13, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 0f64f3f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67879df5d1d74c0008da449c
😎 Deploy Preview https://deploy-preview-1848--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 13, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 0f64f3f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67879df5e2c4c30008912a0f
😎 Deploy Preview https://deploy-preview-1848--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@curdaj curdaj force-pushed the feat/ds-1618-useClassNamePrefix-for-utility branch 2 times, most recently from ceaa9b7 to 656d73d Compare January 13, 2025 13:07
@curdaj curdaj marked this pull request as ready for review January 13, 2025 13:14
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners January 13, 2025 13:14
literat
literat approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good. Thanks for the refactor and adding missing tests 👍

@curdaj curdaj force-pushed the feat/ds-1618-useClassNamePrefix-for-utility branch from 97bcdc7 to 5104f2e Compare January 14, 2025 12:57
@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Jan 14, 2025
@curdaj curdaj force-pushed the feat/ds-1618-useClassNamePrefix-for-utility branch from 5104f2e to 52ed250 Compare January 14, 2025 13:34
@curdaj curdaj force-pushed the feat/ds-1618-useClassNamePrefix-for-utility branch from 52ed250 to 0f64f3f Compare January 15, 2025 11:37
@curdaj curdaj merged commit d4ded97 into main Jan 15, 2025
23 checks passed
@curdaj curdaj deleted the feat/ds-1618-useClassNamePrefix-for-utility branch January 15, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@curdaj curdaj

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curdaj @literat @crishpeen