Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Clean up colors dictionary #DS-1545 #1855

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Refactor: Clean up colors dictionary #DS-1545 #1855

merged 5 commits into from
Jan 21, 2025

Conversation

curdaj
Copy link
Contributor

@curdaj curdaj commented Jan 16, 2025

Description

Additional context

Issue reference

@github-actions github-actions bot added the feature New feature or request label Jan 16, 2025
@curdaj curdaj changed the title Refactor: Clear up colors dictionary #DS-1545 Refactor: Clean up colors dictionary #DS-1545 Jan 16, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 2983eb8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/678f6c88d8769e0008437e4d

@curdaj curdaj force-pushed the feat/ds-1545-clear-action-colors-dictionary branch from d807fe8 to c87d024 Compare January 16, 2025 09:25
@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 2983eb8
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/678f6c883aaae100089ab2ef
😎 Deploy Preview https://deploy-preview-1855--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

crishpeen
crishpeen reviewed Jan 16, 2025
View reviewed changes
docs/DICTIONARIES.md Outdated Show resolved Hide resolved
packages/web-react/src/types/shared/dictionaries.ts Outdated Show resolved Hide resolved
packages/web-react/src/types/shared/dictionaries.ts Outdated Show resolved Hide resolved
@curdaj curdaj force-pushed the feat/ds-1545-clear-action-colors-dictionary branch from 125df20 to 4ae5109 Compare January 16, 2025 12:39
@curdaj curdaj marked this pull request as ready for review January 16, 2025 12:40
@curdaj curdaj requested review from literat, pavelklibani and a team as code owners January 16, 2025 12:40
crishpeen
crishpeen reviewed Jan 16, 2025
View reviewed changes
docs/DICTIONARIES.md Outdated Show resolved Hide resolved
docs/DICTIONARIES.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Button/demo/ButtonDemoFactory.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/demo/ButtonLinkDemoFactory.tsx Outdated Show resolved Hide resolved
packages/web-react/src/constants/dictionaries.ts Show resolved Hide resolved
@curdaj curdaj requested a review from adamkudrna as a code owner January 17, 2025 12:21
@curdaj curdaj added the run-visual-tests Runs visual regression testing on this PR label Jan 17, 2025
crishpeen
crishpeen approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12828973324/artifacts/2446691584

@crishpeen
Copy link
Member

https://github.com/lmc-eu/spirit-design-system/blob/main/packages/web/src/scss/components/Spinner/README.md please update this as well

and unfortunately, we need to update twig as well, otherwise e2e will fail locally
https://github.com/lmc-eu/spirit-design-system/blob/main/packages/web-twig/src/Resources/components/Spinner/__tests__/__fixtures__/spinnerDefault.twig (and snapshot)
https://github.com/lmc-eu/spirit-design-system/blob/main/packages/web-twig/src/Resources/components/Spinner/stories/SpinnerColors.twig

@curdaj
Copy link
Contributor Author

curdaj commented Jan 17, 2025

https://github.com/lmc-eu/spirit-design-system/blob/main/packages/web/src/scss/components/Spinner/README.md please update this as well

and unfortunately, we need to update twig as well, otherwise e2e will fail locally https://github.com/lmc-eu/spirit-design-system/blob/main/packages/web-twig/src/Resources/components/Spinner/__tests__/__fixtures__/spinnerDefault.twig (and snapshot) https://github.com/lmc-eu/spirit-design-system/blob/main/packages/web-twig/src/Resources/components/Spinner/stories/SpinnerColors.twig

So maybe it would be better to create separate fix issue

@curdaj curdaj force-pushed the feat/ds-1545-clear-action-colors-dictionary branch from f21b656 to 87851e6 Compare January 17, 2025 12:57
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12829513745/artifacts/2446834936

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12829855061/artifacts/2446928411

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12847176254/artifacts/2451523767

@crishpeen crishpeen force-pushed the feat/ds-1545-clear-action-colors-dictionary branch from b789cad to 3acf5cd Compare January 18, 2025 20:38
@curdaj curdaj force-pushed the feat/ds-1545-clear-action-colors-dictionary branch from 3acf5cd to f4d55ce Compare January 21, 2025 09:43
@curdaj curdaj force-pushed the feat/ds-1545-clear-action-colors-dictionary branch from f4d55ce to 2983eb8 Compare January 21, 2025 09:44
@curdaj curdaj merged commit 380af52 into main Jan 21, 2025
35 checks passed
@curdaj curdaj deleted the feat/ds-1545-clear-action-colors-dictionary branch January 21, 2025 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@curdaj curdaj

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@curdaj @crishpeen @literat