-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Introduce Vertical Navigation #DS-1627 #1861
Conversation
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
b2eebd0
to
7184850
Compare
Did you add this to the appropriate issue or did you create a new one? If no, please do so. Thanks :-) |
Shouldn't the open menu item have also the hover state? |
@curdaj is already working on it :) We will do it in one issue (as agreed on planning), but it will be a separate PR, so it is not too big. |
7184850
to
d34b9f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
7c92423
to
6b53eb6
Compare
6b53eb6
to
8fe93f9
Compare
20055d4
to
c2483aa
Compare
c2483aa
to
9d34fd1
Compare
9d34fd1
to
5bf6cf5
Compare
5f754f8
to
155fa26
Compare
Description
direction
prop to Navigation with Direction dictionary and withhorizontal
as a default valueAdditional context
Issue reference