Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce sharable ESlint configuration #1918

Merged
merged 11 commits into from
Feb 21, 2025
Merged

Introduce sharable ESlint configuration #1918

merged 11 commits into from
Feb 21, 2025

Conversation

literat
Copy link
Collaborator

@literat literat commented Feb 6, 2025 •
edited
Loading

Description

Removing copied ESLint configurations as preparation for migration to ESLint v9.

Additional context

Issue reference

@literat literat requested review from pavelklibani, curdaj and a team as code owners February 6, 2025 15:37
@literat literat marked this pull request as draft February 6, 2025 15:37
@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit cfbb9b1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67b85ce901ec1d0008f0ab87

@netlify Netlify
Copy link

netlify bot commented Feb 6, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit cfbb9b1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67b85ce9134f6f00082b6d08
😎 Deploy Preview https://deploy-preview-1918--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the style/eslint-config-spirit branch from 5707312 to 48e4245 Compare February 18, 2025 14:35
@literat literat marked this pull request as ready for review February 18, 2025 16:13
@literat literat force-pushed the style/eslint-config-spirit branch from a70d9be to ba3d343 Compare February 20, 2025 10:18
@coveralls
Copy link

coveralls commented Feb 20, 2025 •
edited
Loading

Coverage Status

coverage: 96.838%. remained the same
when pulling cfbb9b1 on style/eslint-config-spirit
into c2bc78a on main.

@literat literat force-pushed the style/eslint-config-spirit branch from ba3d343 to cfbb9b1 Compare February 21, 2025 11:00
@literat literat merged commit d2c3b7b into main Feb 21, 2025
35 checks passed
@literat literat deleted the style/eslint-config-spirit branch February 21, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@curdaj curdaj Awaiting requested review from curdaj curdaj is a code owner

@katerinarehorkova katerinarehorkova Awaiting requested review from katerinarehorkova katerinarehorkova is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen is a code owner

Assignees

@literat literat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@literat @coveralls @pavelklibani