Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-twig): Introduce ValidationText has Icons #DS-1676 #1953

Open
wants to merge 1 commit into
base: feat/ds-1676-validation-text-icons-react
Choose a base branch
from
Open

Feat(web-twig): Introduce ValidationText has Icons #DS-1676 #1953

wants to merge 1 commit into from

Conversation

katerinarehorkova
Copy link

Description

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1676

@github-actions github-actions bot added the feature New feature or request label Feb 19, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 8075777
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/67b87d2f08dc4800081c4efd
😎 Deploy Preview https://deploy-preview-1953--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 1 from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@katerinarehorkova katerinarehorkova changed the base branch from main to feat/ds-1676-validation-text-icons-react February 19, 2025 13:48
@netlify Netlify
Copy link

netlify bot commented Feb 19, 2025 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 8075777
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/67b87d2feba9340008e6daf5
😎 Deploy Preview https://deploy-preview-1953--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@katerinarehorkova katerinarehorkova marked this pull request as ready for review February 19, 2025 13:57
@literat
Copy link
Collaborator

literat commented Feb 20, 2025

I think my comment in https://github.com/lmc-eu/spirit-design-system/pull/1952/files#r1963758012 can be also applied here.

@katerinarehorkova katerinarehorkova force-pushed the feat/ds-1676-validation-text-icons-react branch from 93be9a1 to c06a167 Compare February 21, 2025 12:53
@katerinarehorkova katerinarehorkova force-pushed the feat/ds-1676-validation-text-icons-react branch from c06a167 to b85aa9d Compare February 21, 2025 13:06
@katerinarehorkova katerinarehorkova force-pushed the feat/ds-1676-validation-text-icons-twig branch from 82254bf to 8075777 Compare February 21, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@katerinarehorkova katerinarehorkova

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katerinarehorkova @literat