Server: Config defaults to root and Datadir #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #193 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 135 149 +14
======================================
- Misses 135 149 +14 ☔ View full report in Codecov by Sentry. |
|
Thanks. I'll have a closer look this weekend. Catching up. |
|
I'm happy to have this PR be the "follow-up" to #192 as discussed in #192 (comment) 😄. Would you be okay to broaden the scope a bit as I imagine there's a dependency there anyway? |
|
@dunxen sure, i'll take it! |
|
#192 has been merged now if that helps! |
|
@dunxen ty! I'll take over it |
a-mpch
force-pushed
the
lndk_conf_from_different_sources
branch
2 times, most recently
from
16eaaac to
46959fa
Compare
|
I guess code coverage is broken? |
Yeah I'll sort that out. No worries. |
LNDK is already using a datadir to store TLS certificates. In this PR we default LNDK config and data to ~/.lndk. Datadir is moved inside the default dir ~/.lndk/data. Then, we expect lndk.conf file to be iether in root of the project, or the default LNDK config folder or --config flag. Precedence is flag > root > default dir.
a-mpch
force-pushed
the
lndk_conf_from_different_sources
branch
from
46959fa to
a2b42b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #183
In this PR
Similar to bitcoin
~/.bitcoin/bitcoin.confand~/.lnd/lnd.conf, we add ~./lndk as default path to store conf file.Added some prevalence root project conf.file wouldn't be overriden by lndk dir conf file.
We move the datadir to defaults to
~/.lndk/data. If~/.lndkdoes not exists, it tries to create it.We don't store it inside networks yet as LNDK does not have a concept of network in server, but it does using cli
How can i test it?
Add some files with different configurations:
lndk.confin root project~/.lndk/lndk.confTest which configurations are used. Easy way to do it is to point to different lnd servers and point
addressin each file to each of them.Why this?
Standardness and ease when deploying