Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server: Config defaults to root and Datadir #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config_spec.toml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ doc = "The hex encoded macaroon to pass directly into LNDK"
[[param]]
name = "data_dir"
type = "String"
doc = "The path to the lndk data directory. By default this is stored in ~/.lndk"
doc = "The path to the lndk data directory. By default this is stored in ~/.lndk/data"

[[param]]
name = "log_file"
Expand Down
4 changes: 3 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,10 @@ pub fn init_logger(config: LogConfig) {
pub const DEFAULT_SERVER_HOST: &str = "127.0.0.1";
pub const DEFAULT_SERVER_PORT: u16 = 7000;
pub const LDK_LOGGER_NAME: &str = "ldk";
pub const DEFAULT_DATA_DIR: &str = ".lndk";
pub const DEFAULT_DATA_DIR: &str = "data";
pub const DEFAULT_LNDK_DIR: &str = ".lndk";
pub const DEFAULT_LOG_FILE: &str = "lndk.log";
pub const DEFAULT_CONFIG_FILE_NAME: &str = "lndk.conf";

pub const TLS_CERT_FILENAME: &str = "tls-cert.pem";
pub const TLS_KEY_FILENAME: &str = "tls-key.pem";
Expand Down
37 changes: 28 additions & 9 deletions src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@
use lndk::server::{generate_tls_creds, read_tls, LNDKServer};
use lndk::{
lndkrpc, setup_logger, Cfg, LifecycleSignals, LndkOnionMessenger, OfferHandler,
DEFAULT_DATA_DIR, DEFAULT_LOG_FILE, DEFAULT_SERVER_HOST, DEFAULT_SERVER_PORT,
DEFAULT_CONFIG_FILE_NAME, DEFAULT_DATA_DIR, DEFAULT_LNDK_DIR, DEFAULT_LOG_FILE,
DEFAULT_SERVER_HOST, DEFAULT_SERVER_PORT,
};
use lndkrpc::offers_server::OffersServer;
use log::{error, info};
use std::ffi::OsString;
use std::fs::create_dir_all;
use std::path::PathBuf;
use std::path::{Path, PathBuf};
use std::process::exit;
use std::sync::Arc;
use tokio::select;
Expand All @@ -33,13 +35,13 @@

#[tokio::main]
async fn main() -> Result<(), ()> {
let config = Config::including_optional_config_files(&["./lndk.conf"])
let paths = get_conf_file_paths();
let config = Config::including_optional_config_files(paths)

Check warning on line 39 in src/main.rs

View check run for this annotation

Codecov / codecov/patch

src/main.rs#L38-L39

Added lines #L38 - L39 were not covered by tests
.unwrap_or_exit()
.0;

let data_dir = create_data_dir(&config.data_dir)
.map_err(|e| println!("Error creating LNDK's data dir {e:?}"))?;

let data_dir = create_data_dir(&config.data_dir).map_err(|e| {
println!("Error creating LNDK's data dir: {:?}", e);
})?;

Check warning on line 44 in src/main.rs

View check run for this annotation

Codecov / codecov/patch

src/main.rs#L42-L44

Added lines #L42 - L44 were not covered by tests
let log_file = config.log_file.map(PathBuf::from).or(config
.data_dir
.map(|data_dir| PathBuf::from(data_dir).join(DEFAULT_LOG_FILE)));
Expand Down Expand Up @@ -161,14 +163,31 @@
Ok(())
}

// Creates lndk's data directory at the specified directory, or ~/.lndk if not specified.
// Creates lndk's data directory at the specified directory, or ~/.lndk/data if not specified.
// Process must have write access to the directory.
fn create_data_dir(data_dir: &Option<String>) -> Result<PathBuf, std::io::Error> {
let path = match data_dir {
Some(dir) => PathBuf::from(&dir),
None => home_dir().unwrap().join(DEFAULT_DATA_DIR),
None => get_default_lnkd_dir_path().join(DEFAULT_DATA_DIR),

Check warning on line 171 in src/main.rs

View check run for this annotation

Codecov / codecov/patch

src/main.rs#L171

Added line #L171 was not covered by tests
};

create_dir_all(&path)?;

Ok(path)
}

fn get_default_lnkd_dir_path() -> PathBuf {
home_dir().unwrap().join(DEFAULT_LNDK_DIR)
}

Check warning on line 181 in src/main.rs

View check run for this annotation

Codecov / codecov/patch

src/main.rs#L179-L181

Added lines #L179 - L181 were not covered by tests

fn get_conf_file_paths() -> Vec<OsString> {
let default_lndk_config_path = get_default_lnkd_dir_path()
.join(DEFAULT_CONFIG_FILE_NAME)
.into_os_string();
let current_dir_conf_file = Path::new("./")
.join(DEFAULT_CONFIG_FILE_NAME)
.into_os_string();

let paths = vec![current_dir_conf_file, default_lndk_config_path];
paths
}

Check warning on line 193 in src/main.rs

View check run for this annotation

Codecov / codecov/patch

src/main.rs#L183-L193

Added lines #L183 - L193 were not covered by tests
Loading