Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cert path option for cli #146

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

benthecarman
Copy link
Contributor

No description provided.

@orbitalturtle orbitalturtle self-requested a review July 31, 2024 21:44
Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (d69aecc) to head (6235886).

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #146   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines          97      97           
======================================
  Misses         97      97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@orbitalturtle orbitalturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me, just one nit really.

src/cli.rs Outdated Show resolved Hide resolved
src/cli.rs Outdated Show resolved Hide resolved
@benthecarman
Copy link
Contributor Author

Thanks for the PR! Looks good to me, just one nit really.

Fixed

@orbitalturtle
Copy link
Collaborator

@benthecarman Tested and works great. Just needs a rebase!

@benthecarman
Copy link
Contributor Author

done!

@orbitalturtle orbitalturtle merged commit 6459123 into lndk-org:master Aug 9, 2024
10 checks passed
@benthecarman benthecarman deleted the cert-path branch August 9, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants