Add dockerfile and sample docker compose #176
Conversation
There was a problem hiding this comment.
What are expected commands to be run? I did like following and it doesn't work.
docker build . --tag lndk
docker compose --file sample-docker-compose.yaml upGot error:
I added a inline comment relates to this error.
Error response from daemon: Mounts denied:
The path /root/lnd is not shared from the host and is not known to Docker.
| restart: unless-stopped | ||
| stop_grace_period: 15m30s | ||
| volumes: | ||
| - /root/lnd:/root/.lnd |
There was a problem hiding this comment.
Using root directory of a host file systems(/root/lnd) seems not a good idea for me.
Is this standard way in docker?
There was a problem hiding this comment.
The standard I've seen is lnd:/root/.lnd or something similar, can we change it to that @niteshbalusu11?
|
|
||
| lndk: | ||
| container_name: lndk | ||
| image: lndk |
There was a problem hiding this comment.
Replacing with build . seems better?
We don't have any plans to upload lndk images to a repository at the moment, so building them locally seems sufficient.
There was a problem hiding this comment.
Yeah, I like the idea of replacing image with build. That way, if a user hasn't built lndk yet, they can still use the docker compose file.
| @@ -0,0 +1,27 @@ | |||
| services: | |||
| lnd: | |||
There was a problem hiding this comment.
Can we run lnd without any config and bitcoind?
|
Sorry, I'll fix this PR. I completely forgot about it. |
|
@niteshbalusu11 No worries, thanks for doing it in the first place! Also, if you could squash the commits into one that would be great. |
Closes #147.