Offers: send payment #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbitalturtle
commented
Jan 23, 2024
tests/integration_tests.rs
Outdated
| lnd.connect_to_peer(pubkey, addr).await; | ||
| lnd.connect_to_peer(pubkey_2, addr_2).await; | ||
| let lnd_info = lnd.get_info().await; | ||
| let lnd_pubkey = PublicKey::from_str(&lnd_info.identity_pubkey).unwrap(); |
There was a problem hiding this comment.
So... before LDK 20 this integration test worked ok without channels set up. But now, it doesn't. IIUC LDK 20 requires a node to be in the network graph so it can find a way to forward a message, meaning channels need to be set up rather than just connections to peers. Planning to look into this further and ask the LDK team about it.
There was a problem hiding this comment.
Fixed this with a small PR to rust-lightning to export a lower level version of "send_onion_message" in ldk-sample so we can set the path directly (like we did before) and get around the channels-required issue. lightningdevkit/rust-lightning#2868
orbitalturtle
force-pushed
the
invoice-verification
branch
2 times, most recently
from
6522401 to
2bcd34b
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
d67956e to
2b72d7c
Compare
carlaKC
reviewed
Jan 29, 2024
carlaKC
reviewed
Jan 29, 2024
orbitalturtle
force-pushed
the
invoice-verification
branch
from
2bcd34b to
f439ca3
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
2b72d7c to
8d7d885
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
3 times, most recently
from
48bb807 to
c9c7d63
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
3 times, most recently
from
b41c013 to
b1d8e94
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
from
c9c7d63 to
c99be37
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
b1d8e94 to
8a8b2a4
Compare
carlaKC
reviewed
Feb 2, 2024
orbitalturtle
force-pushed
the
invoice-verification
branch
2 times, most recently
from
c5a0640 to
5230aac
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
8a8b2a4 to
a479edc
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
from
5230aac to
b221d0e
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
a479edc to
b574ebf
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
from
b221d0e to
6468dcf
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
b574ebf to
fc061b7
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
from
6468dcf to
c58fbe8
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
fc061b7 to
9821994
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
2 times, most recently
from
89423f4 to
c3a4f7d
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
9821994 to
2184d97
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
3 times, most recently
from
cbcb32a to
661e889
Compare
carlaKC
reviewed
Feb 16, 2024
| ldk1.stop().await; | ||
| ldk2.stop().await; | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we also look up the payment in LND and assert that it was successfully paid?
There was a problem hiding this comment.
At the end of pay_offer we wait for trackpayment to return success so not sure we need to? But you know the lnd api better than me, would it be worth to use listpayments and double confirm that the payment succeeded?
orbitalturtle
force-pushed
the
invoice-verification
branch
from
c3a4f7d to
be2714c
Compare
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
2 times, most recently
from
3c0d2ee to
fe63c9e
Compare
orbitalturtle
force-pushed
the
invoice-verification
branch
from
be2714c to
df53046
Compare
We use a custom version of tonic_lnd that has the blinded route support in the QueryRoute and SendToRoute commands, which won't officially be released in lnd until v18.
We update to ldk v20 for the latest blinded route updates, namely being able to create a blinded route that's more than one hop. On top of that we use a custom versoin with a small change, which we need in order to send an onion message along a specified path for LNDK's integration tests: lightningdevkit/rust-lightning#2868
orbitalturtle
force-pushed
the
offers-send-payment-new
branch
from
fe63c9e to
4b491cc
Compare
carlaKC
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes the BOLT 12 offer flow by sending the payment. Depends on #89