Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: update branch instructions #95

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

carlaKC
Copy link
Collaborator

@carlaKC carlaKC commented Mar 2, 2024

We no longer need a custom branch + explain why we need dev mode.

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (41a226c) to head (9599cd7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #95   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines          12      13    +1     
======================================
- Misses         12      13    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niteshbalusu11
Copy link

Lgtm.

Copy link
Collaborator

@orbitalturtle orbitalturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I fixed the clippy issue in one of the offers PRs: a6ef7f4

I'd be fine with just merging this as is since #87 should be merged soon anyway.

@carlaKC carlaKC merged commit e4f5512 into lndk-org:master Mar 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants