Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add soroban and update to newest version of rfjs #15

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

willemneal
Copy link

No description provided.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for loam-home failed.

Name Link
🔨 Latest commit 1b3f7d3
🔍 Latest deploy log https://app.netlify.com/sites/loam-home/deploys/655272b5a6e4510008bdb060

Copy link
Contributor

@chadoh chadoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the best way for me to review this? Seems like it's still pretty in-progress, from the first look through the code. Maybe having you show me around would be more useful than me reading it? Should I try to run it locally? Start with the shuttle app stuff?

@@ -38,6 +38,7 @@ type MethodDefinition = {
}

export async function getContractData(contract?: string): Promise<SerializableContractData | undefined> {
debugger;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is before I understood it was serverside.

It's all a mess.

@@ -0,0 +1,133 @@
import * as naj from "near-api-js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is soroban/index?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's all throughout. I just wanted to get to the point where the frontend would print out the schema.

@willemneal
Copy link
Author

I am clueless in this repo. I just wanted to add the schema generation, but it still seems the near integration is tighter throughout, not just the soroban/index.ts.

There is no need to worry about the shuttle stuff it's in the schema generation. Which does print the schema on the server side so I know it's working.

Perhaps syncing on this later would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants