Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ› fix: Fix GitHub model fetch #4645

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

BrandonStudio
Copy link
Contributor

Refactor OpenAICompatibleFactory

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  • Fix GitHub models method.
  • Refactor models parameter of OpenAICompatibleFactory.

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

Fix #4547 (3/3).

This PR should not be merged before #4260.

Refactor OpenAICompatibleFactory
Copy link

vercel bot commented Nov 8, 2024

@BrandonStudio is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

๐Ÿ‘ @BrandonStudio

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 98.14%. Comparing base (679211d) to head (3f8fa5e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4645      +/-   ##
==========================================
+ Coverage   91.95%   98.14%   +6.19%     
==========================================
  Files         548       12     -536     
  Lines       41423     2913   -38510     
  Branches     2511      311    -2200     
==========================================
- Hits        38091     2859   -35232     
+ Misses       3332       54    -3278     
Flag Coverage ฮ”
app ?
server 98.14% <รธ> (+0.01%) โฌ†๏ธ

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@BrandonStudio BrandonStudio changed the title Fix GitHub model fetch โ™ป๏ธ refactor: Fix GitHub model fetch Nov 24, 2024
@BrandonStudio BrandonStudio marked this pull request as ready for review November 25, 2024 01:48
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Nov 25, 2024
@arvinxx arvinxx changed the title โ™ป๏ธ refactor: Fix GitHub model fetch ๐Ÿ› fix: Fix GitHub model fetch Dec 17, 2024
@arvinxx
Copy link
Contributor

arvinxx commented Dec 17, 2024

@BrandonStudio ่ƒฝrebaseไธ‹mainไธ๏ผŸๅ†่ท‘ไธ‹ๅ•ๆต‹ๅ’Œๆž„ๅปบ๏ผŒ่ƒฝ่ฟ‡ๅฐฑๅˆไบ†

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ


@BrandonStudio Can you rebase main? Then run the single test and build, if you can pass it, itโ€™s fine.

@BrandonStudio
Copy link
Contributor Author

Will you squash or merge directly? It seems that there is no conflict

@arvinxx
Copy link
Contributor

arvinxx commented Dec 18, 2024

I will squash it. You can just merge main. I need to trigger the CI again before merging.

@BrandonStudio
Copy link
Contributor Author

Automatically merged. Hope nothing unexpected happened

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
lobe-chat-preview โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 18, 2024 4:05am

@arvinxx arvinxx merged commit b69dce3 into lobehub:main Dec 18, 2024
6 of 8 checks passed
@lobehubbot
Copy link
Member

โค๏ธ Great PR @BrandonStudio โค๏ธ

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
้กน็›ฎ็š„ๆˆ้•ฟ็ฆปไธๅผ€็”จๆˆทๅ้ฆˆๅ’Œ่ดก็Œฎ๏ผŒๆ„Ÿ่ฐขๆ‚จ็š„่ดก็Œฎ! ๅฆ‚ๆžœๆ‚จๅฏน LobeHub ๅผ€ๅ‘่€…็คพๅŒบๆ„Ÿๅ…ด่ถฃ๏ผŒ่ฏทๅŠ ๅ…ฅๆˆ‘ไปฌ็š„ discord๏ผŒ็„ถๅŽ็งไฟก @arvinxx ๆˆ– @canisminor1990ใ€‚ไป–ไปฌไผš้‚€่ฏทๆ‚จๅŠ ๅ…ฅๆˆ‘ไปฌ็š„็งๅฏ†ๅผ€ๅ‘่€…้ข‘้“ใ€‚ๆˆ‘ไปฌๅฐ†ไผš่ฎจ่ฎบๅ…ณไบŽ Lobe Chat ็š„ๅผ€ๅ‘๏ผŒๅˆ†ไบซๅ’Œ่ฎจ่ฎบๅ…จ็ƒ่Œƒๅ›ดๅ†…็š„ AI ๆถˆๆฏใ€‚

github-actions bot pushed a commit that referenced this pull request Dec 18, 2024
### [Version&nbsp;1.36.33](v1.36.32...v1.36.33)
<sup>Released on **2024-12-18**</sup>

#### ๐Ÿ› Bug Fixes

- **misc**: Fix GitHub model fetch.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fix GitHub model fetch, closes [#4645](#4645) ([b69dce3](b69dce3))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

๐ŸŽ‰ This PR is included in version 1.36.33 ๐ŸŽ‰

The release is available on:

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Dec 19, 2024
### [Version&nbsp;1.78.13](v1.78.12...v1.78.13)
<sup>Released on **2024-12-19**</sup>

#### โ™ป Code Refactoring

- **misc**: Refactor the drizzle code style.

#### ๐Ÿ› Bug Fixes

- **misc**: Fix GitHub model fetch, fix pdf preview with capital ext.

#### ๐Ÿ’„ Styles

- **misc**: Improve home page loading for better UX.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor the drizzle code style, closes [lobehub#5058](https://github.com/bentwnghk/lobe-chat/issues/5058) ([4057ad3](4057ad3))

#### What's fixed

* **misc**: Fix GitHub model fetch, closes [lobehub#4645](https://github.com/bentwnghk/lobe-chat/issues/4645) ([b69dce3](b69dce3))
* **misc**: Fix pdf preview with capital ext, closes [lobehub#5074](https://github.com/bentwnghk/lobe-chat/issues/5074) ([3f9470f](3f9470f))

#### Styles

* **misc**: Improve home page loading for better UX, closes [lobehub#5075](https://github.com/bentwnghk/lobe-chat/issues/5075) ([99026bb](99026bb))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "Get Model List" clears out Github models
3 participants