Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15.
Or at least I think it does, I'm not entirely sure.
I'm not sure what the
destroy
function does/did. As far as I could tell it was actually not used, but I might misunderstand the design here.In addition to the issue with the icon on Macs, I now also discovered that one can't use Rsvg.jl on juliabox because of the Gtk.jl dependency, so I think getting rid of that is even more beneficial than we originally thought.
It would be absolutely awesome if we could fix this quickly and tag a new release. I will give an official julia tutorial on Thu, and one of the packages I want to show off is https://github.com/fredo-dedup/VegaLite.jl, and I just now realized that it doesn't work on juliabox because of that Gtk.jl dependency. I would totally understand if we can't manage such a short turn around on such short notice, but I thought I might still ask :)