Merge pull request #105 from local-first-web/invite-rejection

Improve invite rejection
local-first-web · May 23, 2024 · 7485c51 · 7485c51
2 parents faf57f4 + f025cab
commit 7485c51
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/auth-provider-automerge-repo/src/AuthProvider.ts b/packages/auth-provider-automerge-repo/src/AuthProvider.ts
@@ -624,7 +624,6 @@ export class AuthProvider extends EventEmitter<AuthProviderEvents> {
   #removeConnection(shareId: ShareId, peerId: PeerId) {
     const connection = this.#connections.get([shareId, peerId])
     if (connection && connection.state !== 'disconnected') {
-      connection.stop()
       this.#connections.delete([shareId, peerId])
     }
   }

diff --git a/packages/auth-provider-automerge-repo/src/test/AuthProvider.test.ts b/packages/auth-provider-automerge-repo/src/test/AuthProvider.test.ts
@@ -160,9 +160,13 @@ describe('auth provider for automerge-repo', () => {
       invitationSeed: 'passw0rd',
     })
 
-    // grrr foiled again
-    const authWorked = await authenticatedInTime(alice, eve)
-    expect(authWorked).toBe(false) // ✅
+    // alice learns that eve should kick rocks
+    const { message: aliceMessage } = await eventPromise(alice.authProvider, 'localError')
+    expect(aliceMessage).toBe("The peer's invitation wasn't accepted")
+
+    // eve gets told to kick rocks
+    const { message: eveMessage } = await eventPromise(eve.authProvider, 'remoteError')
+    expect(eveMessage).toBe("Your invitation wasn't accepted")
 
     teardown()
   })