add citi bike data application #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
approved these changes
May 19, 2024
There was a problem hiding this comment.
Looks great, kudos for adding this in here @HarshCasper ! 🎉
| @@ -1,2 +1 @@ | |||
| # samples-snowflake | |||
There was a problem hiding this comment.
I think a short top-level README could help, actually - maybe we could add something in here in a follow-up iteration. (but not critical, shouldn't block the merge..)
|
|
||
| ### Configure Snowflake CLI | ||
|
|
||
| To seed the Citibike data into Snowflake, you need to configure the Snowflake CLI with a `local` profile. You can use the following command to create a new profile: |
There was a problem hiding this comment.
nit: I've noticed that we're using the profile name localstack in the docs here: https://snowflake.localstack.cloud/user-guide/integrations/snow-cli/#create-a-connection-profile . Perhaps we could unify the profile name over time. (again, not a blocker)
(no strong preference, but maybe we could unify the docs around local, as that is slightly shorter to type out)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.