Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility with 4.0 #15

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Conversation

cloutierMat
Copy link
Contributor

@cloutierMat cloutierMat commented Nov 25, 2024

Motivation

While getting the sample app setup and testing the different features showcased in the README, I found a few minor issues

Changes

  • Modified the bin/ephemeral.sh script. Api keys are deprecated and showcasing the use of the cli seems more appropriate than the internal route
  • Fixed broken link in README
  • Renamed test/requirements.text to test/requirements.txt
  • Also fixed another little bug I found when playing with the ci built. If a quizz had less that 3 results, the leaderboard would stay blank and nothing would show.

@cloutierMat cloutierMat self-assigned this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

@HarshCasper HarshCasper merged commit 691a912 into main Nov 26, 2024
2 checks passed
@HarshCasper HarshCasper deleted the update-compatibility-with-4.0 branch November 26, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants