Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify demo app CORS setup, use S3 website instead of Web server #47

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Simplify demo app CORS setup, use S3 website instead of Web server #47

merged 2 commits into from
Feb 1, 2023

Conversation

whummer
Copy link
Member

@whummer whummer commented Jan 25, 2023 •
edited
Loading

This PR contains some simplifications to make the sample app easier to install and more self-contained:

  • use S3 website hosting for the Web UI instead of spinning up a separate Web server on 3000
  • given we're accessing the LS APIs from an S3 website (http://localhost:4566/archive-bucket/index.html), we can simplify the CORS setup - it is no longer required to set EXTRA_CORS_ALLOWED_ORIGINS=...
  • remove old/deprecated config variables like DOCKER_BRIDGE or START_WEB=1

Addresses #44

Depends on localstack/localstack#7554

@whummer whummer requested a review from HarshCasper January 25, 2023 14:13
@whummer whummer mentioned this pull request Jan 25, 2023
Merged
@whummer whummer requested a review from tinyg210 January 27, 2023 16:22
tinyg210
tinyg210 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@tinyg210 tinyg210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected 👍

@whummer whummer merged commit 6fb612c into master Feb 1, 2023
@whummer whummer deleted the s3-website branch February 1, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinyg210 tinyg210 tinyg210 approved these changes

@HarshCasper HarshCasper Awaiting requested review from HarshCasper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whummer @tinyg210