Test against Pythons 3.5 and 3.6 #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlevin
force-pushed
the
test-py35-py36
branch
from
d3093d0 to
6d6cc43
Compare
romanlevin
force-pushed
the
test-py35-py36
branch
from
6d6cc43 to
c0981c0
Compare
|
Is this in a good state to be merged? |
|
@jheld well at this point I’d add 3.7. Personally I’d remove support for 3.x versions older than 3.5, too, but not in this PR. |
|
We ended up using fakeredis (recently did, we hadn't used any mocking ones, until about a month ago!). Unsure how much movement this project is seeing, but if any, probably good to give it a shot in some form). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.