Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #130 and #131: Support Lua in Python 3 and improve mock signatures #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

beamerblvd
Copy link

@beamerblvd beamerblvd commented Oct 31, 2017

  • Uses a Python-3 compatible Lunatic-Python library from PyPi
  • Updates the mock Lua script object to not use Python version-specific builtins / behavior
  • Updates the mock Lua script to support redis.status_reply and redis.error_reply in Lua scripts
  • Updates the mock Lua script to support unicode
  • Updates the signatures of the patching functions to support from_url and Mock-specific kwargs
  • Updates the Travis build to run Lua tests, and to also test on Python 3.5 and 3.6
  • Updates the Lua tests to be Python 3 compatible

@beamerblvd beamerblvd changed the title Fix issues 130 and 131: Support Lua in Python 3 and improve mock signatures Fix issues #130 and #131: Support Lua in Python 3 and improve mock signatures Oct 31, 2017
@beamerblvd beamerblvd force-pushed the make-lua-python3-ready branch from 54f4f99 to c793b89 Compare November 1, 2017 18:19
@beamerblvd beamerblvd force-pushed the make-lua-python3-ready branch from e8d2864 to ee65860 Compare November 1, 2017 20:36
@beamerblvd
Copy link
Author

Would love to get a review of this. Currently monkey-patching it in our project, but would prefer to use it unpatched. :-)

LuaLock = threading.Lock()

if sys.version_info[0] == 3:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 2 should be the special case here. In future, when Python 4 gets released, this if will fallback to the logics for Python 2, which will definitely be incompatible with Python 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants