Pinocchio v3 compatibility #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 43eba1e.
ResidualModelFactory was allocating the content of a `std::shared_ptr` manually (with a new). On GNU/Linux with G++, the standard library use free to deallocate this memory. This is an undefined behavior that cause random error on at least test_residual unit test.
… with cppadcodegen
This fix probably hide a bigger issue in the Python binding.
for more information, see https://pre-commit.ci
|
As you can see in the commit history, @jorisv is doing most of the work, and deserve the credits :) |
|
NB: there is another blocking pointsthan what we can see here. It is being worked on, in private spaces. @LudovicDeMatteis will be able to provide a green light when everything will be ready enough for him. update: this was stack-of-tasks/pinocchio#2247, and is not related to crocoddyl. Sorry for the false alarm. |
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
May 31, 2024
Changed in v2.1.0: * Updated black + isort + flake8 to ruff in loco-3d/crocoddyl#1256 * Exported version for Python in loco-3d/crocoddyl#1254 * Added pinocchio 3 preliminary support in loco-3d/crocoddyl#1253 * Updated CMake packaging in loco-3d/crocoddyl#1249 * Fixed ruff reported error in loco-3d/crocoddyl#1248 * Fixed yapf reported errors in loco-3d/crocoddyl#1238 * Tested Python stubs in Conda CI in loco-3d/crocoddyl#1228 * Fixed Rviz display in loco-3d/crocoddyl#1227 * Improved CI, updated cmake and fixed launch file in loco-3d/crocoddyl#1220 * Introduced a Rviz display in loco-3d/crocoddyl#1216 * Enabled display of thrust and simplied displayers code in loco-3d/crocoddyl#1215 * Introduced floating base thruster actuation model in loco-3d/crocoddyl#1213 * Fixed quadruped and biped examples in loco-3d/crocoddyl#1208 * Fixed terminal computation in Python models in loco-3d/crocoddyl#1204 * Fixed handling of unbounded values for `ActivationBounds` in loco-3d/crocoddyl#1191
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Jun 20, 2024
Changed in v2.1.0: * Updated black + isort + flake8 to ruff in loco-3d/crocoddyl#1256 * Exported version for Python in loco-3d/crocoddyl#1254 * Added pinocchio 3 preliminary support in loco-3d/crocoddyl#1253 * Updated CMake packaging in loco-3d/crocoddyl#1249 * Fixed ruff reported error in loco-3d/crocoddyl#1248 * Fixed yapf reported errors in loco-3d/crocoddyl#1238 * Tested Python stubs in Conda CI in loco-3d/crocoddyl#1228 * Fixed Rviz display in loco-3d/crocoddyl#1227 * Improved CI, updated cmake and fixed launch file in loco-3d/crocoddyl#1220 * Introduced a Rviz display in loco-3d/crocoddyl#1216 * Enabled display of thrust and simplied displayers code in loco-3d/crocoddyl#1215 * Introduced floating base thruster actuation model in loco-3d/crocoddyl#1213 * Fixed quadruped and biped examples in loco-3d/crocoddyl#1208 * Fixed terminal computation in Python models in loco-3d/crocoddyl#1204 * Fixed handling of unbounded values for `ActivationBounds` in loco-3d/crocoddyl#1191
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Jul 1, 2024
Changed in v2.1.0: * Updated black + isort + flake8 to ruff in loco-3d/crocoddyl#1256 * Exported version for Python in loco-3d/crocoddyl#1254 * Added pinocchio 3 preliminary support in loco-3d/crocoddyl#1253 * Updated CMake packaging in loco-3d/crocoddyl#1249 * Fixed ruff reported error in loco-3d/crocoddyl#1248 * Fixed yapf reported errors in loco-3d/crocoddyl#1238 * Tested Python stubs in Conda CI in loco-3d/crocoddyl#1228 * Fixed Rviz display in loco-3d/crocoddyl#1227 * Improved CI, updated cmake and fixed launch file in loco-3d/crocoddyl#1220 * Introduced a Rviz display in loco-3d/crocoddyl#1216 * Enabled display of thrust and simplied displayers code in loco-3d/crocoddyl#1215 * Introduced floating base thruster actuation model in loco-3d/crocoddyl#1213 * Fixed quadruped and biped examples in loco-3d/crocoddyl#1208 * Fixed terminal computation in Python models in loco-3d/crocoddyl#1204 * Fixed handling of unbounded values for `ActivationBounds` in loco-3d/crocoddyl#1191
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.