Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata fields can't start with column #2165

Open
theosanderson opened this issue Jun 18, 2024 · 2 comments
Open

Metadata fields can't start with column #2165

theosanderson opened this issue Jun 18, 2024 · 2 comments
Labels
website Tasks related to the web application

Comments

@theosanderson
Copy link
Member

theosanderson commented Jun 18, 2024

I guess that means that metadata fields may not start with column_ anymore? Not something for this PR but I wonder whether we should separate the technical search params from the metadata query params. Otherwise, after releasing Loculus, such a change would be considered a major breaking change.

For example, we could introduce a prefix such as $ for all technical params and then define that metadata columns may not start with $. If we want to do that, we should do it before launching the MVP as it will cause broken links.

Originally posted by @chaoran-chen in #1993 (comment)

See the whole thread - things aren't handled well for query parameters generally atm such that adding a random query param leads to a crash. Fix before launch.

@theosanderson theosanderson added this to the MVP milestone Jun 18, 2024
@chaoran-chen chaoran-chen moved this to Backlog in Planning Jul 8, 2024
@chaoran-chen chaoran-chen modified the milestones: MVP, MVP (nice to have) Jul 8, 2024
@anna-parker anna-parker added high_priority Work on this as soon as possible (potentially post-MVP) website Tasks related to the web application labels Aug 15, 2024
@chaoran-chen chaoran-chen removed the high_priority Work on this as soon as possible (potentially post-MVP) label Feb 14, 2025
@chaoran-chen
Copy link
Member

We originally wanted to implement it before launch but didn't. How should we proceed with this? If we now implement it, it could break existing links, but I still do prefer having a clearer separation between metadata fields and technical parameters.

@theosanderson
Copy link
Member Author

Despite the fact that this would be harder to change later, to me it's still a very niche concern that I would personally rank below most of our other issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Tasks related to the web application
Projects
Status: Backlog
Development

No branches or pull requests

3 participants