Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination (or lazy load) to review page to a) load faster and b) reduce website memory requirements #2884

Closed
corneliusroemer opened this issue Sep 26, 2024 · 2 comments
Labels
feature Feature proposal website Tasks related to the web application

Comments

@corneliusroemer
Copy link
Contributor

Helps resolve #2881

We should add pagination to the review page results to not have to keep a large datastructure in website memory. Website should make paginated requests to db for the review results.

@corneliusroemer corneliusroemer added website Tasks related to the web application feature Feature proposal labels Sep 26, 2024
@theosanderson
Copy link
Member

Yes - when I re-designed this page my idea was that there would simply be an endpoint that would return all the data needed to render one version of the page. There was resistance (or it was too much work) to doing this, but I think it may make sense to do the two things at once: stop the current lazy-loading whereby the actual information for each sequence card displayed is made in a separate query per card, and ensure proper pagination.

@theosanderson
Copy link
Member

Closing in favour of #3031 if that's OK (with this issue still useful to capture the detail)

@theosanderson theosanderson closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature proposal website Tasks related to the web application
Projects
None yet
Development

No branches or pull requests

2 participants