Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review page: Confusing error message regarding "display name" if underlying field is wrong #3566

Closed
chaoran-chen opened this issue Jan 21, 2025 · 2 comments · Fixed by #3567
Closed

Review page: Confusing error message regarding "display name" if underlying field is wrong #3566

chaoran-chen opened this issue Jan 21, 2025 · 2 comments · Fixed by #3567
Labels
bug Something isn't working preprocessing Issues related to the preprocessing component

Comments

@chaoran-chen
Copy link
Member

I uploaded a slightly adapted version of the CCHF data from the example data (to Pathoplexus staging) and then changed the collection date on the review page to "2020-01-00" and got the below view and error message:

Image

It is unexpected that the "Display Name" field is marked as an error and there is an error message "displayName: Metadata field displayName: Date format is not recognized.".

I assume that this is caused because the collection date is part of the display name and, therefore, the display name could not be computed but the error message is quite confusing.
@chaoran-chen chaoran-chen added bug Something isn't working preprocessing Issues related to the preprocessing component labels Jan 21, 2025
@theosanderson
Copy link
Member

This is to some extent a duplicate (or relation) of #3460 where I describe some of the things we would want to change to fix these issues.

@theosanderson theosanderson mentioned this issue Jan 22, 2025
Merged
@chaoran-chen
Copy link
Member Author

Ah, sorry, I somehow didn't find it... I'll close this one.

@chaoran-chen chaoran-chen closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working preprocessing Issues related to the preprocessing component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(website): Don't propagate date parsing errors to concatenated fields loculus-project/loculus
2 participants
@chaoran-chen @theosanderson