Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resorting search page table by a new column / direction should reset pagination to page 1 #3665

Closed
theosanderson opened this issue Feb 11, 2025 · 1 comment · Fixed by #3667
Closed

Resorting search page table by a new column / direction should reset pagination to page 1 #3665

theosanderson opened this issue Feb 11, 2025 · 1 comment · Fixed by #3667

Comments

@theosanderson
Copy link
Member

Currently you stay on the same arbitrary page, which is confusing
@chaoran-chen
Copy link
Member

Duplicate of #2044 ;)

theosanderson added a commit that referenced this issue Feb 11, 2025
@theosanderson
fix(website): pagination reset on search page table resort
fbc9d89 
Fixes #3665

Update `setOrderByField` and `setOrderDirection` functions to reset pagination to page 1 when sorting.

* Modify `setOrderByField` to set the page state to '1' when changing the order by field.
* Modify `setOrderDirection` to set the page state to '1' when changing the order direction.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/loculus-project/loculus/issues/3665?shareId=XXXX-XXXX-XXXX-XXXX).
@theosanderson theosanderson mentioned this issue Feb 11, 2025
Merged
theosanderson added a commit that referenced this issue Feb 11, 2025
@theosanderson
fix(website): pagination reset on search page table resort (#3667)
a47d51a 
Fixes #3665

Update `setOrderByField` and `setOrderDirection` functions to reset pagination to page 1 when sorting.

* Modify `setOrderByField` to set the page state to '1' when changing the order by field.
* Modify `setOrderDirection` to set the page state to '1' when changing the order direction.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/loculus-project/loculus/issues/3665?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(website): pagination reset on search page table resort loculus-project/loculus
2 participants
@chaoran-chen @theosanderson