Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce sequences ram usage #371

Closed
wants to merge 4 commits into from
Closed

Reduce sequences ram usage #371

wants to merge 4 commits into from

Conversation

helpau
Copy link
Contributor

@helpau helpau commented Jan 6, 2025 •
edited
Loading

No description provided.

Your Name added 4 commits January 6, 2025 17:31
@helpau helpau requested a review from ckrause as a code owner January 6, 2025 13:40
@helpau
Copy link
Contributor Author

helpau commented Jan 6, 2025

shrink_to_fit increase peak RAM usage

@helpau helpau closed this Jan 6, 2025
@helpau
Copy link
Contributor Author

helpau commented Jan 6, 2025 •
edited
Loading

The correct solution is:

  1. Count lines = number of lines in the file
  2. Allocate memory for lines of elements
    I won't do this PR yet (because of edge cases like an empty line at the end of the file), but it should improve data locality.

@helpau helpau deleted the reduce_sequences_ram_usage branch January 6, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckrause ckrause Awaiting requested review from ckrause ckrause is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@helpau