-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor tweaks and highlights #149
Minor tweaks and highlights #149
Conversation
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any places in the doc where we reference the name of a resource (vcluster, namespace), can you put it into a code format?
On the rest of this page, there are some references to a vcluster, but it should be capitalized as vCluster
|
||
## Create the HA virtual cluster | ||
|
||
To create a virtual cluster using the vcluster CLI, we run the vcluster create command. To enable HA, we’ll need to specify the distro and the values.yaml file to use: | ||
To create a virtual cluster using the vcluster CLI, we run the `vcluster create` command. To enable HA, we’ll need to specify the distro and the vcluster.yaml file to use: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put vcluster.yaml
in a code formatting in this part as well as any other reference in the doc.
We’ve named the virtual cluster ha-tutorial. By default, the vcluster create command connects to the virtual cluster, but for the purposes of this tutorial, we’ve disabled that with the --connect=false flag. And we’ve specified the distro and the values.yaml file to use when creating the virtual cluster. | ||
We’ve named the virtual cluster ha-tutorial. By default, the `vcluster create` command connects to the virtual cluster, | ||
but for the purposes of this tutorial, we’ve disabled that with the `--connect=false flag`. | ||
We’ve also specified the distro and the vcluster.yaml file to use when creating the virtual cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line We’ve also specified the distro and the vcluster.yaml file to use when creating the virtual cluster.
as it's more specific to the old way of deploying.
Puts resources in code format Replaces "virtual cluster" with vCluster instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I don't think we have put vCluster
into code formatting throughout the docs, so I would remove that, but consdiering how slow to review this PR, I'll update it as a quick follow-up PR.
No description provided.