Hooks pro pods add image pull secrets #338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Hooks example for adding `imagePullSecrets` to all vCluster workload pods.
✅ Deploy Preview for vcluster-docs-site ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Could you please allow edits by maintainers, so I can help you with |
Removed all 'we'
Removed the word 'functionality'
|
The Vale issue is related to using "Hooks (Pro)". I believe we use this formatting in multiple places. If we are going to change it to satisfy Vale, what should it be changed to? "Hooks (pro)"? Also, can't add comment in source as this Vale issue is for something that was not changed in the PR. |
Piotr1215
reviewed
Nov 8, 2024
remove 'an' from 'for an examples'
|
@kmadel, apologies for back and forth on this one, I had to add the vale exception in different file. If you rebase again the rule should work correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the vCluster vcluster.yaml configuration provides the workloadServiceAccount that allows including
imagePullSecrets, it is limited as thatserviceAccountis superseded when usingsync.toHost.pods.serviceAccounts.enabled: true.This allows setting
imagePullSecretsat the pod level instead of via aserviceAccount- although it does rely on a Pro feature.