Variety of changes for PHP agent #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or backwards compatibility,
…rds compatibility, updated tests Separated logger classes into multiple files to keep with common OOP PHP library development. Prefixed classes with Loggr so as to not pollute global space with common terms such as Event or Events, etc. Added static functions for semi-backwards compatibility. In test.php an example showed LogClient() created Loggr::LogClient, but of course Loggr_LogClient could be used as well.
- nl2br instead of str_replace - comments - use ' instead of " unless new line
Loggr Fluent Events - deprecated formatting methods in favor of method with formatting support - removed latitude and longitude in geo method in favor of geo var, added support for IP address (either defined or automatic) - updated post method to require text attribute or bail returning this (optional: turn off suppress errors so you can debug) - updated value to cast all input as float (since Loggr doc says it does it too) - added addValue and subValue which adds value by input or subtracts value by input, respectively - added support for arrays of tags, joins array by space - added trimming of input to all methods to reduce unnecessary white space and bytes - added datatype comparison of case-insensitive 'html' to either use html or plaintext Loggr Log Client - cleaned up spacing and added geo support - added tag array test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a number of changes to the PHP agent. Each commit is the iteration of changes and should describe what I did. In brief:
I tried to keep this as backwards compatible as possible, but for various reasons something are not possible. I will work on updated the Markdown file for instructions and more detail use of the library.
Lastly, have not tested in < PHP 5.3 so will need to do that... :/
Let me know if you notice anything or what-not.