Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet_detection #19

Open
wants to merge 8 commits into
base: v1.3.2-branch_v2
Choose a base branch
from
Open

Conversation

rostyslavhereha
Copy link

No description provided.

Copy link

@jplapp jplapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we use repeatdataset?


def objective(trial):
# # Define the hyperparameter search space
res = trial.suggest_categorical("resolution", [384]) # square resolutions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would use smaller resolution, 256 should be plenty (lower resolution -> smaller model -> less overfit)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that I didn't make any changes for optimisation, so I left them here. These parameters are not used during training manually, and will be adjusted before the start.

heatmap_size=(48, 64),
sigma=2,
unbiased=True)
type='MSRAHeatmap', input_size=(448, 448), heatmap_size=(112, 112), sigma=2)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even larger?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I will set the change that is adjusted before training to a lower value by default (224x224)


# pipelines
train_pipeline = [
dict(type='LoadImage'),
dict(type='GetBBoxCenterScale'),
dict(type='RandomFlip', direction='horizontal'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I misunderstood you, but on the call we decided to remove it, I can return it.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my question was: can we return it? so, does it generate correct annotations?

Probably the anwer is no, right? because then the bottom left would be bottom right

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then, to get more data, it might be useful to do a custom version of it, that flips the keypoints and also left/right names

@rostyslavhereha
Copy link
Author

do we use repeatdataset?

No

@rostyslavhereha
Copy link
Author

@jplapp
To make it clearer, I've taken out the configuration in pallet_ketpoints.py and everything we use in it. So the questions to be solved are should we add RandomFlip and Repeat Dataset?

@jplapp
Copy link

jplapp commented Feb 14, 2025

I think using RepeatDataset would be helpful. Could you also commit the changes now used for training?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants