feature(ci): Nomos Node release page #1005
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
youngjoon-lee
approved these changes
Jan 31, 2025
Comment on lines
+179
to
+187
| ## Checklist | ||
| Before publishing please ensure: | ||
| - [ ] Description is complete | ||
| - [ ] Changelog is correct | ||
| - [ ] Assets for all platforms exist | ||
| - [ ] Pre-release is checked if necessary | ||
| - [ ] Remove this checklist before publishing the release. | ||
| draft: true | ||
| prerelease: true |
There was a problem hiding this comment.
This checklist is for reminding us of a final check just before removing the prerelease badge?
There was a problem hiding this comment.
Actually, that'd be the draft; but yes.
prerelease should be set to false, I believe, as it's intended to mark a beta or alpha release (or the likes of).
danielSanchezQ
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR implement?
Release page for Nomos Node. Produces a release page from a hardcoded template and attaches the bundled binaries.
There's still room for improvement although that's left for a future iteration. If you want to double check what's remaining of this task, please check this issue.
A draft release page has been produced by this workflow. You can check it in the releases page or go to the specific release.
Closes: #1002
2. Does the code have enough context to be clearly understood?
Yes
3. Who are the specification authors and who is accountable for this PR?
N/A
4. Is the specification accurate and complete?
N/A
5. Does the implementation introduce changes in the specification?
No
Checklist
Warning
Do not merge the PR if any of the following is missing: