make quoted capture less greedy when we have unambiguous separator #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [logstash-plugins#60][], GitHub user @robcowart reports that in some scenarios we can fail to split on match of `field_split_pattern`. The example given is a partially-quoted value, with additional bytes between it and the unambiguous separator, followed by another key and quoted value. Since the quoted value isn't immediately followed by a field splitter, our semi-greedy quoted-value capture was too greedy, continuing to consume until it found a close-quote that would be followed by either a field-split or EOF. Here, we become much less greedy, capturing any sequence of characters that is _not_ the close-quote character. [logstash-plugins#60]: logstash-plugins#60
|
CI failing because of elastic/logstash-devutils#73 |
jsvd
approved these changes
May 11, 2018
spec/filters/kv_spec.rb
Outdated
| } | ||
| } | ||
|
|
||
| context '' do |
There was a problem hiding this comment.
since there's no context here, can we just move the it block one level back?
There was a problem hiding this comment.
d'oh, will fix this and do the merge on Monday.
yaauie
force-pushed
the
partially-quoted-values-with-unambiguous-separator
branch
from
9646eb5 to
21eee81
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
…racters Closes: logstash-plugins#52 Resolves: logstash-plugins#59
yaauie
force-pushed
the
partially-quoted-values-with-unambiguous-separator
branch
from
21eee81 to
5be7b60
Compare
webmat
reviewed
May 16, 2018
| expect(event.get("foo")).to eq('bar') | ||
| expect(event.get("baz")).to eq('"quoted stuff" and more unquoted') | ||
| expect(event.get("msg")).to eq('fully-quoted with a part! of the separator') | ||
| expect(event.get("blip")).to eq('this!!!!!is it') |
|
This looks good. |
:-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a couple separate fixes, that rely on each other; each fix is
documented in its own separate commit, but the commits must be applied in
order.
Greediness of Quoted Values
Greediness of
trim_keyandtrim_valueoperations